nbconvert: Jinjaless exporter base #4175
Conversation
| @@ -100,14 +100,14 @@ def export(exporter, nb, **kw): | |||
| #Check arguments | |||
| if exporter is None: | |||
| raise TypeError("Exporter is None") | |||
| elif not isinstance(exporter, Exporter) and not issubclass(exporter, Exporter): | |||
| elif not isinstance(exporter, TemplateExporter) and not issubclass(exporter, TemplateExporter): | |||
There was a problem hiding this comment.
Yes that would be better, good catch
|
@Carreau review? |
|
Yes, slowly coming back from holidays, and caching up, but as always PhD first, and as my boss is back too, getting up to speed is not easy. |
|
Need a rebase that I tried to force push on #3747 but github see the wrong commits after I reopened the PR... |
|
@Carreau , rebased |
|
+1 |
|
Sweet, unless there are objections, I'll merge sometime tomorrow, @minrk ? |
|
@jdfreder do not merge yourself, let someone else merge. |
If you could, that would be great |
| default_template = Unicode(u'') | ||
| template = Any() | ||
| environment = Any() | ||
| # finish the docstring |
There was a problem hiding this comment.
has a todo mark for finishing the docstring, do you want to finish it?
|
Looks like the rebase didn't quite go as planned - there look to be a few find/replace errors and remaining calls to transform. Also don't forget to add at least a simple exercise test that goes through the motions of the nb2nb Exporter. |
Also fixed some small things in template exporter tests.
Apparently, gah! 😦 I wonder if that happened the second rebase around? It didn't ask for my intervention, but it did complain about some files. Anyways, I addressed your comments, thanks, and I added a few small tests. |
add base Exporter class above TemplateExporter
add base Exporter class above TemplateExporter
@Carreau said he would be away for a week and gave me permission to rebase his PR #3747 .